fix: correct fyers holdings mapping for investment value and avg price#1053
Open
preet225 wants to merge 4 commits intomarketcalls:mainfrom
Open
fix: correct fyers holdings mapping for investment value and avg price#1053preet225 wants to merge 4 commits intomarketcalls:mainfrom
preet225 wants to merge 4 commits intomarketcalls:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct Fyers holdings data mapping
Resolved issues where:
Updated fyers order_data mapping to correctly transform holdings data.
Now the holdings page correctly shows:
Tested on local OpenAlgo dashboard.
Summary by cubic
Fixes Fyers holdings mapping so Avg Price, LTP, Total Investment Value, and PnL% display correctly in the dashboard. Maps
costPricetoaverage_price, setsproductfromholdingType, rounds to 2 decimals, and computespnlpercentwith a divide-by-zero guard.Written for commit fe407f9. Summary will update on new commits.